Add google analytics #153
Merged
Add google analytics #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joannechen1223
approved these changes
Feb 29, 2024
| }); | ||
|
|
||
| if (!clientEnvRes.success) { | ||
| // console.error(clientEnvRes.error.issues); |
There was a problem hiding this comment.
[nit] do we need this?
There was a problem hiding this comment.
I think we should preserve this so that if other developers (assume we have other dev in our team) run the app on their local machine without proper .env, an error will be thrown to let them know. Plus, we can catch the env error when testing before merging into prod.
| @@ -1,7 +1,8 @@ | |||
| import { cn } from "@/utils/cn"; | |||
There was a problem hiding this comment.
[nit] change the filename to camel case
There was a problem hiding this comment.
Ahh, that makes sense but actually this is kind of a frontend convention to name this file like this.
Ref:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add google analytics to track viewers and gain insight into users' behaviors.
Related Issue
Notes
zodto parse environment variables.By doing so, if you have a misconfiguration in your
.env(e.g. you forget to add some env vars), it will result in build-time error (for server config) or run-time error (for client-config). So that you can identify bugs when testing or building. It's better since the bug or error can be identified earlier before deploying to prod.Testing link: https://rec-f8x3073i7-recnet-542617e7.vercel.app/
TODO