Skip to content

Commit

Permalink
Refactor user mapping in inviteCodes route
Browse files Browse the repository at this point in the history
  • Loading branch information
swh00tw committed Mar 6, 2024
1 parent b8ce71c commit 79f9637
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions apps/recnet/src/app/api/inviteCodes/route.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { db } from "@/firebase/admin";
import { inviteCodeSchema } from "@/types/inviteCode";
import { UserSchema } from "@/types/user";
import { User, UserSchema } from "@/types/user";
import { notEmpty } from "@/utils/notEmpty";

export async function GET() {
Expand Down Expand Up @@ -31,15 +31,21 @@ export async function GET() {
return null;
})
);
const usersMap: Record<string, User> = users
.filter(notEmpty)
.reduce((acc, user) => {
return {
...acc,
[user.id]: user,
};
}, {});

// join users to invite codes
const inviteCodesWithUsers = inviteCodes.docs
.map((inviteCode) => {
const inviteCodeData = inviteCode.data();
const user = users.find((user) => user?.id === inviteCodeData.usedBy);
const owner = users.find(
(user) => user?.id === inviteCodeData.issuedTo
);
const user = usersMap[inviteCodeData.usedBy];
const owner = usersMap[inviteCodeData.issuedTo];
const res = inviteCodeSchema.safeParse({
...inviteCodeData,
issuedTo: owner,
Expand Down

0 comments on commit 79f9637

Please sign in to comment.