Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: ruff python 3.8 & update warning #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sam-hey
Copy link

@sam-hey sam-hey commented Jan 30, 2025

Align Ruff with setup.py: Set Python version to 3.8 for Ruff to ensure consistency with setup.py

python_requires=">=3.8",

Clarify warning message: Update the warning to explicitly state that the model configuration is being loaded, rather than a model from Stanford NLP.

@NohTow
Copy link
Collaborator

NohTow commented Feb 2, 2025

About the warning message: we not only load the configuration of the stanford-nlp model, but also the weights.
Actually, we more load the weights than the config, as I wanted to load more information from the model config by reading artificat.metada, such as the max doc/query length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants