Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Setting normalize_scores default to False #66

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

NohTow
Copy link
Collaborator

@NohTow NohTow commented Oct 15, 2024

This PR change the default of normalize_scores to False and add documentation about the parameters.
The rationale behind this change is two-fold:

  1. The setup is not really common for the large audience and the user can be surprised by the loss magnitude. Also, if the user use his own dataset without normalizing the teacher scores, it could be hurting the performance.
  2. JinaColBERT-v2 had mitigated results using normalization, so I am not sure it is worth it to make it the default.

Before merging, there is two things that needs to be discussed:

  1. The datasets we have released have normalized scores, which could make the boilerplate a bit off.
  2. When building the functionality, I decoupled the normalization of the output scores and the teachers' to offload part of the computation pre-training as it would be re-usable. But now that I think about it again, it might be more painful for the user and we could add the normalization of the teacher scores during the training aswell.

Related issue: #59

@raphaelsty
Copy link
Collaborator

raphaelsty commented Jan 30, 2025

@NohTow Merging this PR

@raphaelsty raphaelsty merged commit 4d1d410 into main Jan 30, 2025
2 checks passed
@raphaelsty raphaelsty self-requested a review January 30, 2025 10:41
raphaelsty added a commit that referenced this pull request Jan 30, 2025
…tion"

This reverts commit 4d1d410, reversing
changes made to e349918.
raphaelsty added a commit that referenced this pull request Jan 30, 2025
Revert "Merge pull request #66 from lightonai/default_to_no_normaliza…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants