Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapdb: add minimalistic test framework for testing DB migrations #707

Merged
merged 7 commits into from
Dec 9, 2023
Merged

tapdb: add minimalistic test framework for testing DB migrations #707

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8769305
tapdb: extract DB migration into method
guggero Nov 29, 2023
65176ff
tapd: allow migration target version to be specified
guggero Nov 29, 2023
cdedffd
tapdb: add NewTestDBWithVersion
guggero Nov 29, 2023
6f66242
tapdb: allow DB schema errors to be detected
guggero Nov 29, 2023
5d739ba
internal/test: add ReadTestDataFile
guggero Nov 29, 2023
97b85bd
tapdb: wrap error in QueryAssets
guggero Nov 29, 2023
efeb01c
tapdb: add test that demoes DB migration testing
guggero Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tapdb/assets_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ func fetchAssetsWithWitness(ctx context.Context, q ActiveAssetsStore,
// First, we'll fetch all the assets we know of on disk.
dbAssets, err := q.QueryAssets(ctx, assetFilter)
if err != nil {
return nil, nil, fmt.Errorf("unable to read db assets: %v", err)
return nil, nil, fmt.Errorf("unable to read db assets: %w", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}

assetIDs := fMap(dbAssets, func(a ConfirmedAsset) int64 {
Expand Down