Unlock Coins on Anchor TX Broadcast Failure #1348
Open
+41
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user encountered an error where the anchor transaction fee was reported to be lower than the wallet's minimum relay fee. To provide more context, log the minimum relay fee as reported by the wallet.
The absolute fee is already reported. This change calculates and reports the final fee rate using the virtual size of the completed transaction.
ffranr
force-pushed
the
unlock-coins-on-broadcast-fail
branch
2 times, most recently
from
3d7d78e to
8dba8e6
Compare
Pull Request Test Coverage Report for Build 13118260360Details
💛 - Coveralls |
Introduce a new send state to act as a threshold for transfer cancellation handling. After this state, the anchor transaction may already be in the mempool or confirmed on-chain. Before reaching this point, however, the broadcast may have failed, requiring different handling.
Update unlock logic to ensure that errors encountered during the anchor tx broadcast process, but before reaching the broadcast complete state, result in coins being unlocked. This prevents assets from remaining locked in case of intermediate failures.
Ensure locked asset coins are released before returning an error when attempting to publish the anchor transaction. Without this change, if the chain bridge logic determines the anchor transaction should not be broadcast, the coins remain locked, leaving the send attempt stuck in limbo.
ffranr
force-pushed
the
unlock-coins-on-broadcast-fail
branch
from
8dba8e6 to
e0c9661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that asset coins are properly unlocked if an error occurs during the anchor transaction broadcast process. Previously, failed broadcasts could leave coins locked, causing send attempts to be stuck.
Key changes:
SendStateBroadcastCompleteto better define when a transfer can be canceled.