tapdb: fixes another issue with the syncer cache #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure the syncer cache doesn't have any other hidden bugs, we turn it on by default in the integration tests.
This fixes the issue that after a proof is pushed to the universe, the root is invalid because the wrong one was added to the cache.
GeorgeTsagk
approved these changes
Jan 31, 2025
Pull Request Test Coverage Report for Build 13075096022Details
💛 - Coveralls |
gijswijs
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time we activate the syncer cache by default in the integration tests to avoid further issues.
The actual bug fix is quite trivial, the wrong root node was inserted into the cache.