Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoloop: ignore asset channels #881

Merged

Conversation

sputn1ck
Copy link
Member

@sputn1ck sputn1ck commented Jan 31, 2025

This PR adds a check for autoloop to ignore the balance in channels that have custom data (such as asset channels)
As asset channels contain a sat balance, we don't want them to be considered for default btc autoloops.

@sputn1ck sputn1ck force-pushed the autoloop_ignore_asset_chans branch from 0b472e0 to d971381 Compare January 31, 2025 20:21
@sputn1ck sputn1ck self-assigned this Feb 4, 2025
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

liquidity/liquidity.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

liquidity/liquidity.go Outdated Show resolved Hide resolved
liquidity/autoloop_test.go Show resolved Hide resolved
@sputn1ck sputn1ck force-pushed the autoloop_ignore_asset_chans branch from d971381 to 0eaf89c Compare February 7, 2025 09:19
@sputn1ck sputn1ck force-pushed the autoloop_ignore_asset_chans branch from 0eaf89c to 4dd3074 Compare February 7, 2025 09:24
@sputn1ck sputn1ck merged commit 992884c into lightninglabs:master Feb 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants