rustfmt: Run on offers
#3577
rustfmt: Run on offers
#3577
Conversation
|
After the conflicts are resolved here, I don't have a strong opinion on how it's formatted things, so LGTM. |
tnull
force-pushed
the
2025-01-rustfmt-offers
branch
from
16a7ba1 to
ce2a568
Compare
Resolved conflicts. |
| /// [`Bolt12Invoice`] for the request if they could be extracted from the metadata. | ||
| /// | ||
| /// [`Bolt12Invoice`]: crate::offers::invoice::Bolt12Invoice | ||
| pub fn verify_using_metadata<#[cfg(not(c_bindings))] T: secp256k1::Signing>( |
There was a problem hiding this comment.
This one might almost be worth rustfmt::skip'ing. Inline cfgs are confusing to read.
| () => { | ||
| "02080000010000020003" | ||
| }; | ||
| } | ||
| macro_rules! tlv3 { () => { "03310266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c0351800000000000000010000000000000002" } } |
There was a problem hiding this comment.
Why didn't this get updated?
| "010203e8" | ||
| }; | ||
| } | ||
| macro_rules! tlv2 { |
There was a problem hiding this comment.
Should we go ahead and convert these to constants?
| macro_rules! tlv3 { () => { "03310266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c0351800000000000000010000000000000002" } } | ||
| assert_eq!( | ||
| super::root_hash(TlvStream::new(&<Vec<u8>>::from_hex(tlv1!()).unwrap())), | ||
| sha256::Hash::from_slice(&<Vec<u8>>::from_hex("b013756c8fee86503a0b4abdab4cddeb1af5d344ca6fc2fa8b6c08938caa6f93").unwrap()).unwrap(), | ||
| sha256::Hash::from_slice( | ||
| &<Vec<u8>>::from_hex( |
There was a problem hiding this comment.
Can you break these up? The Hash/key(from_hex) unwrap unwrap patterns are really good candidates to clean up in a number of places in this file.
|
Needs rebase, not sure if there's any remaining PRs touching this code? I don't think so. |
We run the formatter on the
offerssub-directory.