Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add label and size to scatter3 #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add label and size to scatter3 #4

wants to merge 2 commits into from

Conversation

felixcheung
Copy link
Contributor

Minor update to scatter3 chart support in lightning-scala:

  • add label array in API with default value
  • add size array in API with default value
  • convert both into lists and add to data map being passed to internal plot call

@freeman-lab
Copy link
Member

Thanks @felixcheung ! Mind adding a description, just so others know what this is? I'll take a look and give feedback soon.

@felixcheung
Copy link
Contributor Author

@freeman-lab just did. thanks.

@freeman-lab
Copy link
Member

@felixcheung this looks great! Could merge as is, but would you like to quickly add alpha and color to the PR so we can get all options in at once? Alpha can be an Array[Float], and color should probably be Array[Array[Int]] or Array[Tuple3], whichever you think is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixcheung @freeman-lab