feat: MIN_ACTIVATION_BALANCE, new correlation penalty #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgorkavenko
changed the title
hweawer
reviewed
Dec 17, 2024
vgorkavenko
force-pushed
the
feat/new-correlation-penalty
branch
from
f0669ad to
0ac1cd2
Compare
F4ever
reviewed
Dec 24, 2024
| slashings = Gwei(bound_slashed_validators_count * MAX_EFFECTIVE_BALANCE) | ||
| # We don't know validators effective balances on the moment of slashing, | ||
| # so we assume that it was at least `effective_balance` | ||
| slashings = Gwei(sum(int(v.validator.effective_balance) for v in bound_slashed_validators)) |
There was a problem hiding this comment.
This breaks compatibility with current version.
Split old and new logic.
Smth like bound_slashed_validators_v0 and bound_slashed_validators_v1_electra and call them depending on network state
There was a problem hiding this comment.
will take forking approach from here #579
vgorkavenko
force-pushed
the
feat/new-correlation-penalty
branch
from
34f72e4 to
72a7af4
Compare
vgorkavenko
force-pushed
the
feat/new-correlation-penalty
branch
from
71acea9 to
8e1c663
Compare
vgorkavenko
force-pushed
the
feat/new-correlation-penalty
branch
from
8e1c663 to
c25df44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.