MAX_CYCLE_LIFETIME_IN_SECONDS only for cycle logic #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F4ever
reviewed
Dec 12, 2024
F4ever
approved these changes
Dec 16, 2024
vgorkavenko
reviewed
Dec 17, 2024
There was a problem hiding this comment.
The changes don't resolve the issue - #390
The code can still throw unhandled exceptions. Probably, because of _receive_last_finalized_slot() and has_contract_address_changed() calls outside the run_cycle
Co-authored-by: Vladimir Gorkavenko <[email protected]>
Addressed this |
vgorkavenko
approved these changes
Dec 17, 2024
madlabman
approved these changes
Dec 17, 2024
F4ever
reviewed
Dec 23, 2024
F4ever
reviewed
Jan 10, 2025
F4ever
reviewed
Jan 10, 2025
F4ever
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.