Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use package rpcFactory #565

Merged
merged 3 commits into from
Jan 20, 2025
Merged

fix: use package rpcFactory #565

merged 3 commits into from
Jan 20, 2025

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Dec 13, 2024 •
edited
Loading

Description

Uses rpcFactory from warehouse, deletes old code

Code review notes

Testing notes

Only apr/rpc is affected, but also code on widget == code in package, so no change at all

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@Jeday Jeday requested review from a team as code owners December 13, 2024 13:47
@preview-stands
Copy link

preview-stands bot commented Dec 13, 2024 •
edited
Loading

Preview stand status

Stand was demolished

solidovic
solidovic previously approved these changes Dec 16, 2024
View reviewed changes
DiRaiks
DiRaiks previously approved these changes Dec 16, 2024
View reviewed changes
@Jeday Jeday dismissed stale reviews from solidovic and DiRaiks via 07bf4ee January 20, 2025 11:12
@jake4take jake4take merged commit ed60911 into develop Jan 20, 2025
6 checks passed
@jake4take jake4take deleted the feature/si-1733-update-rpc-factory-in-widget branch January 20, 2025 16:50
@itaven itaven mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiRaiks DiRaiks DiRaiks approved these changes

@solidovic solidovic solidovic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jeday @solidovic @DiRaiks @jake4take