Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More token to wallet response messages #545

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

bobunderforest
Copy link
Contributor

Description

Displaying "Add tokens to wallet" regardless of wallet capability. Managing responses given from wallet by attempting of adding token.

Checklist:

  • Checked the changes locally.

@bobunderforest bobunderforest requested review from a team as code owners November 20, 2024 13:54
@preview-stands
Copy link

preview-stands bot commented Nov 20, 2024

Preview stand status

Stand was demolished

Jeday
Jeday previously approved these changes Nov 25, 2024
shared/components/token-to-wallet/token-to-wallet.tsx Outdated Show resolved Hide resolved
shared/components/token-to-wallet/token-to-wallet.tsx Outdated Show resolved Hide resolved
@Jeday
Copy link
Contributor

Jeday commented Nov 25, 2024

Generally, like this approach more, than pessimistically disabling this feature for users.

alx-khramov
alx-khramov previously approved these changes Dec 3, 2024
@bobunderforest bobunderforest changed the title WIP: more token to wallet response messages More token to wallet response messages Dec 3, 2024
@bobunderforest bobunderforest dismissed stale reviews from alx-khramov and Jeday via d80e030 December 4, 2024 09:25
Jeday
Jeday previously approved these changes Dec 5, 2024
DiRaiks
DiRaiks previously approved these changes Dec 5, 2024
@Jeday Jeday dismissed stale reviews from DiRaiks and themself via 8abde7c January 21, 2025 06:41
@jake4take jake4take merged commit 6491fbd into develop Jan 21, 2025
6 checks passed
@jake4take jake4take deleted the feature/si-983-add-tokens-to-wallet-button branch January 21, 2025 11:16
@itaven itaven mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants