feat: clean secrets in logs #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: trim evaluated string
chore(release): 2.4.0
Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.2.1...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
feat: support query params passthrough
chore(release): 2.7.0
In the previous version, all messages were logged to the console via the default JavaScript `console.log`. With this logging method, if some error occurs during the interaction with a webhook, its content is logged in the console as part of the error object. In this version, we added Winston logger to the project with the logic of cleaning secrets in logs. All webhook tokens are now added to the secrets after the reading of the config file is completed. Extend info that is printed to the log in case of errors. For network-related errors print response status and request data, for all errors print their stack trace.
Add mock `logger` instance to all tests that use context.
vgorkavenko
reviewed
Jan 20, 2025
Format all multiple-line log messages in one line.
vgorkavenko
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, all messages were logged to the console via the default JavaScript
console.log. With this logging method, if some error occurs during the interaction with a webhook, its content is logged in the console as part of the error object.In this version, we added Winston logger to the project with the logic of cleaning secrets in logs. All webhook tokens are now added to the secrets after the reading of the config file is completed.
Extend info that is printed to the log in case of errors. For network-related errors print response status and request data, for all errors print their stack trace.