Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cygwin fix for SM4 (issue #663) #664

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Cygwin fix for SM4 (issue #663) #664

merged 1 commit into from
Sep 2, 2024

Conversation

karel-m
Copy link
Member

@karel-m karel-m commented Sep 1, 2024

Fix for #663

  • Static functions renamed (using s_ prefix) so that they do not collide with cygwin stuff
  • Added missing #ifdef LTC_TEST

@karel-m karel-m requested review from levitte and sjaeckel September 1, 2024 09:21
sjaeckel
sjaeckel requested changes Sep 1, 2024
View reviewed changes
Copy link
Member

@sjaeckel sjaeckel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like that we also would prevent name clashes as seen when trying to do #596 and the names are still kind of the same from the original and not something entirely different.

src/ciphers/sm4.c Outdated Show resolved Hide resolved
src/ciphers/sm4.c Outdated Show resolved Hide resolved
@karel-m karel-m force-pushed the pr/fix-sm4-on-cygwin branch from 1bf2e71 to 24e31ef Compare September 1, 2024 16:59
levitte
levitte approved these changes Sep 1, 2024
View reviewed changes
Copy link
Collaborator

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karel-m karel-m requested a review from sjaeckel September 1, 2024 18:07
@sjaeckel sjaeckel merged commit e8eb4a0 into develop Sep 2, 2024
75 checks passed
@sjaeckel sjaeckel deleted the pr/fix-sm4-on-cygwin branch September 2, 2024 06:54
@sjaeckel sjaeckel mentioned this pull request Sep 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjaeckel sjaeckel sjaeckel approved these changes

@levitte levitte levitte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karel-m @sjaeckel @levitte