[Discovery] Support add user with access token #1100
Conversation
|
Do you know what software uses the access token variant other than the spotify-connect tool? |
|
No. I think that will be also nice to allow to create the credential files manually with a Spotify token. Because right now it assumes it's a credential with password if it's not a reusable one. But I think that this is one is more flexible as it allows an easy to implement remote way to authenticate the speaker. Already using it and seems to work nicely. As a side topic, the get info call returns an empty string for the field "activeUser". If we expose there the active user id, a remote system will be able to know if the speaker is already authenticated, and also to detect that the credentials are not longer valid because it can check the user id for its active credentials, this way it will now that it should remove the current speaker credentials (witch is currently not possible to do but I read some where that you can do that by sending a delete to the addUser method, so maybe was possible on other implementations or in the dev branch?) and adding the speaker to the new user account. Does this makes sense to you? It's actually not needed for my project because I'm doing those checks by accessing the credentials file, and I'm spawning librespot from my application so I can restart it without any trouble, but I think that is a something nice to have to allow people to handle this remotely. Regards! |
|
To give some context, in my project I keep a valid Spotify token centralized in the server (openHAB) that is obtained from a refresh token you obtain once through the oAuth Spotify authentication flow. This token is always synchronized to the connected clients (a web ui that is connected to the server through ws) so they can use the Web Playback SDK. In the electron version this same token is used to authenticate the built-in Librespot client into the user account. |
|
Hi everyone, thanks for this!
Please base it on
Absolutely. This is also on my list, but not immediately trivial so not something I was planning to take up anytime soon. Any work on this would be highly welcomed. |
Sure, I'll rebase this work to dev, and I will try to add the rest of the functionality mentioned there, thank you! |
|
There's some more background at TimotheeGerber/spotify-connect#1 |
| @@ -42,6 +42,14 @@ impl Credentials { | |||
| } | |||
| } | |||
|
|
|||
| pub fn with_access_token(username: impl Into<String>, token: impl Into<String>) -> Credentials { | |||
There was a problem hiding this comment.
See #1098 (comment)
I think it would be good to not enforce the username here, if possible.
There was a problem hiding this comment.
Sure. I'll align to the work in #1098 which, I think, will add that part.
|
Didn't have time to look at it, I'll reopen it when I have some time, thank you for the feedback! |
Hi,
I have added this changes in order to support adding the client to my account using and access token with the "streaming" scope through the addUser action. It's inspired by the project https://github.com/TimotheeGerber/spotify-connect.
Do you think this can this be merged agains the 0.4.x version and included in the next 0.4.x release? Or is better that I open a pr agains the dev branch?
Hope the code is ok I don't have too much experience with rust.
Regards!
Related to:
#1086 (comment)
#1098