tokio-core => tokio #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading byteorder v1.2 -> v1.3
Upgrading hostname v0.2 -> v0.3
Upgrading multimap v0.4 -> v0.8
Upgrading rand v0.5 -> v0.7
|
Just glanced through, Lgtm :-) |
ashthespy
approved these changes
Apr 15, 2020
|
Well CI seems happy enough. I'm going to merge this in and do what you suggested RE releasing a version for each tokio version. Let me know if you have any issues using in librespot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #4 and #3
All I've done is re-based @ashthespy 's work from #4 onto current master. That did require re-writing some commits though. So I'm making a PR to allow Ash and Ryan to review.