-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
js-peer: add prettier for consistent styling #211
Conversation
2color
commented
Feb 4, 2025
- chore: add prettier for consistent formatting
- chore: run prettier in build command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for setting this up @2color , looks good. Just left a comment.
Also probably we should consider adding a CI job, either using the Prettier Github Action or something like
name: Prettier Check
on:
push:
branches: [ main ]
pull_request:
branches: [ main ]
jobs:
prettier:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '20.x'
- run: npm ci
- run: npx prettier --check .
I agree. Right now we run the check as part of the build, which runs in Fleek. But we should try to build the app in GitHub actions. I'll add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM