Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: introduce libp2p-webrtc-websys behind webrtc-websys feature flag. #5819

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

chore: introduce libp2p-webrtc-websys behind webrtc-websys feature flag. #5819

wants to merge 5 commits into from
+14 −3

Conversation

dariusc93
Copy link
Member

Description

With the promotion of libp2p-webrtc-websys to a non-alpha/stable release, we should also re-export it as apart of libp2p with it being behind a webrtc-websys feature.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@dariusc93 dariusc93 marked this pull request as ready for review January 17, 2025 12:53
dariusc93
dariusc93 commented Jan 17, 2025
View reviewed changes
libp2p/CHANGELOG.md Outdated Show resolved Hide resolved
dariusc93
dariusc93 commented Jan 17, 2025
View reviewed changes
libp2p/CHANGELOG.md Outdated Show resolved Hide resolved
@dariusc93 dariusc93 requested a review from jxs January 17, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs Awaiting requested review from jxs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dariusc93