fix: minor version bump packages affected by #5676 #5811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenaf9
force-pushed
the
fix/bump-core
branch
from
b4ef835 to
dbcfed3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By switching from
void::Voidtostd::convert::Infallible, #5676 changed the output types of someNetworkBehaviorimplementations in different protocols.This can cause a type mismatch for the user and therefore is a breaking change.
#5678 (follow-up PR that version-bumped the crates affected by #5676) only bumped the patch version of the affected crates.
The current PR now changes it to a minor version bump for all crates where types in a
NetworkBehaviorimplementation were affected.It also reverts the version bump and CHANGELOG entry in
libp2p-quicthat was added with #5678, because that crate was never touched by the original PR.Notes & open questions
Change checklist
I have added tests that prove my fix is effective or that my feature works