chore(quic): deprecate QUIC draft-29 version support #5786
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dariusc93
approved these changes
Dec 31, 2024
dariusc93
changed the title
dariusc93
requested changes
Jan 1, 2025
elenaf9
reviewed
Jan 4, 2025
| @@ -59,6 +59,8 @@ pub struct Config { | |||
| /// If support for draft-29 is enabled servers support draft-29 and version 1 on all | |||
| /// QUIC listening addresses. | |||
| /// As client the version is chosen based on the remote's address. | |||
| #[allow(deprecated)] | |||
There was a problem hiding this comment.
I think the #[allow(deprecated)] needs to be applied in all the places where support_draft_29 is used, instead of here where it is declared.
Also, could we use expect instead of allow? expect will give us a warning as soon as the attribute isn't needed anymore, i.e. as soon as the deprecated items are removed.
(Depends on #5650 to update our MSRV to the most recent rust version where expect was stablilized.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate support_draft_version field from QUIC protocol.
resolves #3395
Change checklist