Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gossipsub): remove duplicated call to inbound_transform #5767

Merged
merged 9 commits into from
Jan 16, 2025

Conversation

drHuangMHT
Copy link
Contributor

Description

May close #4369.

Notes & open questions

Internal change: no public API changes.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@drHuangMHT drHuangMHT changed the title chore(gossipsub): remove duplicated call to inbound_transform refactor(gossipsub): remove duplicated call to inbound_transform Jan 2, 2025
Copy link
Contributor

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, rest LGTM. Thanks @drHuangMHT!

protocols/gossipsub/src/behaviour.rs Outdated Show resolved Hide resolved
elenaf9
elenaf9 previously approved these changes Jan 5, 2025
Copy link
Contributor

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this @drHuangMHT. Left a comment!

protocols/gossipsub/src/behaviour.rs Show resolved Hide resolved
jxs
jxs previously approved these changes Jan 16, 2025
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@jxs jxs added the send-it label Jan 16, 2025
Copy link
Contributor

mergify bot commented Jan 16, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot dismissed stale reviews from elenaf9 and jxs January 16, 2025 15:32

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify mergify bot merged commit cc8607c into libp2p:master Jan 16, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(gossipsub): Optimize behaviour's handle_invalid_message
3 participants