Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: identify::Config fields private #5663

Merged
merged 6 commits into from
Nov 6, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
bump to 0.46.0
  • Loading branch information
kamuik16 committed Nov 6, 2024
commit 2b2eb3c86e123df3415348221aeeed92e0a4e9d1
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -84,7 +84,7 @@ libp2p-dcutr = { version = "0.12.0", path = "protocols/dcutr" }
libp2p-dns = { version = "0.42.0", path = "transports/dns" }
libp2p-floodsub = { version = "0.45.0", path = "protocols/floodsub" }
libp2p-gossipsub = { version = "0.48.0", path = "protocols/gossipsub" }
libp2p-identify = { version = "0.45.2", path = "protocols/identify" }
libp2p-identify = { version = "0.46.0", path = "protocols/identify" }
libp2p-identity = { version = "0.2.9" }
libp2p-kad = { version = "0.47.0", path = "protocols/kad" }
libp2p-mdns = { version = "0.46.0", path = "protocols/mdns" }
4 changes: 2 additions & 2 deletions protocols/identify/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## 0.45.2
## 0.46.0

- Make `identify::Config` fields private and added getter functions.
- Make `identify::Config` fields private and add getter functions.
See [PR 5663](https://github.com/libp2p/rust-libp2p/pull/5663).

## 0.45.1
2 changes: 1 addition & 1 deletion protocols/identify/Cargo.toml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ name = "libp2p-identify"
edition = "2021"
rust-version = { workspace = true }
description = "Nodes identification protocol for libp2p"
version = "0.45.2"
version = "0.46.0"
authors = ["Parity Technologies <admin@parity.io>"]
license = "MIT"
repository = "https://github.com/libp2p/rust-libp2p"
12 changes: 6 additions & 6 deletions protocols/identify/src/behaviour.rs
Original file line number Diff line number Diff line change
@@ -204,18 +204,18 @@ impl Config {
}

/// Get the protocol version of the Config.
pub fn protocol_version(&self) -> String {
self.protocol_version.clone()
pub fn protocol_version(&self) -> &str {
&self.protocol_version
}

/// Get the local public key of the Config.
pub fn local_public_key(&self) -> PublicKey {
self.local_public_key.clone()
pub fn local_public_key(&self) -> &PublicKey {
&self.local_public_key
}

/// Get the agent version of the Config.
pub fn agent_version(&self) -> String {
self.agent_version.clone()
pub fn agent_version(&self) -> &str {
&self.agent_version
}

/// Get the interval of the Config.