-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SwarmBuilder): add with_connection_timeout method #5575
Merged
mergify
merged 7 commits into
libp2p:master
from
stormshield-frb:feat/add-connection-timeout-to-swarm-builder
Dec 14, 2024
Merged
feat(SwarmBuilder): add with_connection_timeout method #5575
mergify
merged 7 commits into
libp2p:master
from
stormshield-frb:feat/add-connection-timeout-to-swarm-builder
Dec 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormshield-frb
force-pushed
the
feat/add-connection-timeout-to-swarm-builder
branch
from
August 28, 2024 15:28
df78e2c
to
f78ea9d
Compare
stormshield-frb
force-pushed
the
feat/add-connection-timeout-to-swarm-builder
branch
from
August 28, 2024 15:30
f78ea9d
to
1300365
Compare
dariusc93
reviewed
Sep 5, 2024
…connection-timeout-to-swarm-builder
jxs
force-pushed
the
feat/add-connection-timeout-to-swarm-builder
branch
from
December 13, 2024 19:41
f8122ed
to
2caa95d
Compare
jxs
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks François!
jxs
pushed a commit
to jxs/rust-libp2p
that referenced
this pull request
Jan 6, 2025
Small PR to be able to change the `connection_timeout` value given to the `TransportTimeout` when building the `Swarm` with a `SwarmBuilder`. Pull-Request: libp2p#5575.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small PR to be able to change the
connection_timeout
value given to theTransportTimeout
when building theSwarm
with aSwarmBuilder
.Notes & open questions
Change checklist