Merge branch 'master' into fix/req-resp-max-streams-failure

libp2p · Jun 4, 2024 · 762137c · 762137c
2 parents 661e140 + 68301b8
commit 762137c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/protocols/request-response/CHANGELOG.md b/protocols/request-response/CHANGELOG.md
@@ -3,6 +3,9 @@
 - Report failure when streams are at capacity.
   See [PR 5417](https://github.com/libp2p/rust-libp2p/pull/5417).
 
+- Report dial IO errors to the user.
+  See [PR 5429](https://github.com/libp2p/rust-libp2p/pull/5429).
+
 ## 0.26.2
 
 - Deprecate `Behaviour::add_address` in favor of `Swarm::add_peer_address`.

diff --git a/protocols/request-response/src/handler.rs b/protocols/request-response/src/handler.rs
@@ -242,11 +242,10 @@ where
             }
             StreamUpgradeError::Apply(e) => void::unreachable(e),
             StreamUpgradeError::Io(e) => {
-                tracing::debug!(
-                    "outbound stream for request {} failed: {e}, retrying",
-                    message.request_id
-                );
-                self.requested_outbound.push_back(message);
+                self.pending_events.push_back(Event::OutboundStreamFailed {
+                    request_id: message.request_id,
+                    error: e,
+                });
             }
         }
     }