Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: fullrt #1062

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup: fullrt #1062

wants to merge 1 commit into from

Conversation

guillaumemichel
Copy link
Contributor

Cleaning up fullrt code.

@guillaumemichel guillaumemichel requested a review from a team as a code owner March 6, 2025 14:57
guillaumemichel
guillaumemichel commented Mar 6, 2025
View reviewed changes
fullrt/dht.go
conns := dht.h.Network().ConnsToPeer(p)
var addrs []multiaddr.Multiaddr
for _, conn := range conns {
addr := conn.RemoteMultiaddr()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want to record the current connect addresses since remote nodes could be using upnp, and may not use the same address in the future.

we want to record the listen addresses they share with us using identify, which are stored in the host's peerstore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@guillaumemichel