-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.12 nfs #1273
Open
siva-portworx
wants to merge
97
commits into
master
Choose a base branch
from
2.12-nfs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
2.12 nfs #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ram <[email protected]>
…ation, delete error and multitenancy. Signed-off-by: Priyanshu Pandey <[email protected]>
…tal error. Signed-off-by: Priyanshu Pandey <[email protected]>
Signed-off-by: Priyanshu Pandey <[email protected]>
Signed-off-by: Ram <[email protected]>
Signed-off-by: Ram <[email protected]>
Signed-off-by: Ram <[email protected]>
- validate specs for resource transformation cr - apply patch on unstruct k8s objects - run patched resources on dry run namespace with DryRun option set to all Signed-off-by: Ram <[email protected]>
…-dr setups - query cluster pair token using px endpoint + port - query port by looking at px-api service rest port Signed-off-by: Ram <[email protected]>
- accept resource transformation in migration spec - update resource as per transformation rule Signed-off-by: Ram <[email protected]>
- allow dry run for keypair and slice value type Signed-off-by: Ram <[email protected]>
- addressed review comments Signed-off-by: Ram <[email protected]>
- validate transform CR - dry-run on newly detected object before starting migration Signed-off-by: Ram <[email protected]>
Signed-off-by: Ram <[email protected]>
Signed-off-by: Ram <[email protected]>
Signed-off-by: Ram <[email protected]>
Signed-off-by: Ram <[email protected]>
Fixed a v1beta1 based getCRD call which will fail for k8s-1.22 or more because these APIs are removed in k8s-1.22 onwards. Signed-off-by: Lalatendu Das <[email protected]>
Bumped up the go version required for gotestsum package Signed-off-by: Kesavan Thiruvenkadasamy <[email protected]>
- With fix, we will include all the CRDs of a group, if one CRDs of a parrticular group had a CR in the given namespace.
- added prepareMutatingWebHookForApply, prepareValidatingWebHookForApply, validatingWebHookToBeCollected and mutatingWebHookToBeCollected apis
is a generic backup. - If the backup volume list had only non-kdmp volumes, trigger the post exec rule after the startbackup API. - If the backup volume list had only kdmp volumes or mix of both kdmp and non-kdmp volume, we will call the post exec rule, once the volume backup is completed.
…rt in resourcecollector.
The image registry and namespace details are passed via CR. This is passed to JOB to determine the executor image location. Signed-off-by: Lalatendu Das <[email protected]>
Review Comments Fixing - This is an unwanted file got created during some git operation, hence need to be deleted.
Signed-off-by: Kesavan Thiruvenkadasamy <[email protected]>
all resources status
with timeout value.
…on also while restoring pvcs.
Signed-off-by: Kesavan Thiruvenkadasamy <[email protected]>
For AWS , azure and GCP based volumes we will used kdmp driver to take a backup only when the the backuplocation type is NFS. Signed-off-by: Lalatendu Das <[email protected]>
When Backuplocation type is NFS, then we will use KDMP driver to take backup for CSI volumes. Signed-off-by: Lalatendu Das <[email protected]>
Can one of the admins verify this patch? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1273 +/- ##
==========================================
- Coverage 68.47% 67.46% -1.02%
==========================================
Files 42 42
Lines 4628 4696 +68
==========================================
- Hits 3169 3168 -1
- Misses 1145 1211 +66
- Partials 314 317 +3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Does this PR change a user-facing CRD or CLI?:
Is a release note needed?:
Does this change need to be cherry-picked to a release branch?: