Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.12 nfs #1273

Open
wants to merge 97 commits into
base: master
Choose a base branch
from
Open

2.12 nfs #1273

wants to merge 97 commits into from

Conversation

siva-portworx
Copy link
Contributor

What type of PR is this?

Uncomment only one and also add the corresponding label in the PR:
bug
feature
improvement
cleanup
api-change
design
documentation
failing-test
unit-test
integration-test

What this PR does / why we need it:

Does this PR change a user-facing CRD or CLI?:

Is a release note needed?:

Issue:
User Impact:
Resolution

Does this change need to be cherry-picked to a release branch?:

Ram and others added 30 commits August 3, 2022 23:04
…ation, delete error and multitenancy.

Signed-off-by: Priyanshu Pandey <[email protected]>
  - validate specs for resource transformation cr
  - apply patch on unstruct k8s objects
  - run patched resources on dry run namespace with DryRun option set to
all

Signed-off-by: Ram <[email protected]>
…-dr setups

  - query cluster pair token using px endpoint + port
  - query port by looking at px-api service rest port

Signed-off-by: Ram <[email protected]>
  - accept resource transformation in migration spec
  - update resource as per transformation rule

Signed-off-by: Ram <[email protected]>
 - allow dry run for keypair and slice value type

Signed-off-by: Ram <[email protected]>
   - addressed review comments

Signed-off-by: Ram <[email protected]>
  - validate transform CR
  - dry-run on newly detected object before starting migration

Signed-off-by: Ram <[email protected]>
Fixed a v1beta1 based getCRD call which will fail for k8s-1.22 or more
because these APIs are removed in k8s-1.22 onwards.

Signed-off-by: Lalatendu Das <[email protected]>
Bumped up the go version required for gotestsum package

Signed-off-by: Kesavan Thiruvenkadasamy <[email protected]>
	- With fix, we will include all the CRDs of a group, if one CRDs
          of a parrticular group had a CR in the given namespace.
	- added prepareMutatingWebHookForApply, prepareValidatingWebHookForApply,
	  validatingWebHookToBeCollected and mutatingWebHookToBeCollected apis
is a generic backup.

    - If the backup volume list had only non-kdmp volumes, trigger the
      post exec rule after the startbackup API.
    - If the backup volume list had only kdmp volumes or mix of both
      kdmp and non-kdmp volume, we will call the post exec rule, once the volume backup is completed.
sivakumar subraani and others added 23 commits November 7, 2022 19:08
The image registry and namespace details are passed via CR. This is
passed to JOB to determine the executor image location.

Signed-off-by: Lalatendu Das <[email protected]>
Review Comments Fixing - This is an unwanted file got created during some git operation, hence need to be deleted.
Signed-off-by: Kesavan Thiruvenkadasamy <[email protected]>
Signed-off-by: Kesavan Thiruvenkadasamy <[email protected]>
For AWS , azure and GCP based volumes we will used kdmp driver to take
a backup only when the the backuplocation type is NFS.

Signed-off-by: Lalatendu Das <[email protected]>
When Backuplocation type is NFS, then we will use KDMP driver to take
backup for CSI volumes.

Signed-off-by: Lalatendu Das <[email protected]>
@cnbu-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Patch coverage: 6.84% and project coverage change: -1.02 ⚠️

Comparison is base (9141670) 68.47% compared to head (b57a1c2) 67.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1273      +/-   ##
==========================================
- Coverage   68.47%   67.46%   -1.02%     
==========================================
  Files          42       42              
  Lines        4628     4696      +68     
==========================================
- Hits         3169     3168       -1     
- Misses       1145     1211      +66     
- Partials      314      317       +3     
Impacted Files Coverage Δ
pkg/log/log.go 92.04% <0.00%> (-3.82%) ⬇️
pkg/storkctl/clusterpair.go 23.12% <3.57%> (-4.28%) ⬇️
pkg/schedule/schedule.go 50.71% <30.00%> (-0.96%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants