update key protect go client and also adjust the mock test #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit lift the key protect client version from github.com/IBM/keyprotect-go-client v0.5.1 to github.com/IBM/keyprotect-go-client v0.7.0 which is the latest release available now. Signed-off-by: Humble Chirammal <[email protected]>
|
Cc @leseb |
|
Cc @adityadani |
nixpanic
reviewed
Nov 22, 2021
Thats correct, its a general update as you mentioned @nixpanic , adjusting the commit message. |
As part of the key protect client update new testify package version also has been picked up and the mock tests have been refreshed with the new version Signed-off-by: Humble Chirammal <[email protected]>
Done.. |
|
@adityadani can you please take a look at this PR ? or assign this PR to the correct github id? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lift key protect client to latest version
This commit lift the key protect client version from
which is the latest release available now. This PR also adjust mock tests for key protect secret test