Replaced the secureStringClear mechanism with a SecureString class #1170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the secureStringClear mechanism with a SecureString class
The existing mechanism isn't fully secure. The idea was to fill the old memory of sensitive strings (e.g., auth) with zeros before deallocating the memory. However, the implementation, via the secureStringClear, only really did this on the final destruction of certain objects containing those sensitive strings. That is not sufficient because assignment operations or temporary strings (e.g., urlEncode) would not get the same treatment (e.g. not clearing the old memory deallocated during assignment).
As far as I know, a more reliable (and convenient) way of doing this is through a custom allocator that zeroes out any deallocated memory, and then, define a SecureString as simply a std::string that uses that secure allocator. So, that's what I implemented in this PR.