Build with --locked in CI #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we bumping dependencies manually in Cargo.toml we may end up forgetting about adjusting Cargo.lock in the process, depending on how we go about it. That's not great for users as it will cause spurious changes when they build a checkout. Luckily for us, it's an easy thing to detect: we should build with --locked, which will cause the build process to fail if the two files do not agree. Use it in our CI workflow accordingly. Signed-off-by: Daniel Müller <[email protected]>
|
nice! out of curiosity, how did you discover the locked flag for cargo? |
Thanks for the review! I think I had been aware of it for a while, but for this particular use case it may have been the comments over in #187 that mentioned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we bump dependencies manually in
Cargo.tomlwe may end up forgetting about adjustingCargo.lockin the process, depending on how we go about it. That's not great for users as it will cause spurious changes when they build a checkout.Luckily for us, it's an easy thing to detect: we should build with
--locked, which will cause the build process to fail if the two files do not agree. Use it in our CI workflow accordingly.Signed-off-by: Daniel Müller [email protected]