Remove unbrotli.js and use brotli submodule javascript decompressor

[TFSThiagoBR98]

As mentioned in #105 (comment), this PR replace the unbrotli.js with the Brotli Javascript decompressor from the submodule.

In the future, a decompressor may be implemented in Wasm instead of using Javascript.

@TheOneric, can you review this?

[TheOneric]

The two unbrotli.js commits should be squashed before merge. Apart from a few remarks regarding the Makefile, the diff looks good to me. I assume you verified that this is a working drop-in replacements (apart from the Module patch). Is there an easy, ideally automated way to test JSO changes beyond mere compilation, btw?

[TheOneric]

I've taken the liberty to push the changes I suggested myself, @TFSThiagoBR98 does it look alright to you?

A new commit was added for the patchfile dependencies and the diff between your previous version and the first commit of the new version is this:

diff --git a/Makefile b/Makefile
index ee90824..ace025a 100644
--- a/Makefile
+++ b/Makefile
@@ -70,7 +70,6 @@ $(DIST_DIR)/lib/libexpat.a: build/lib/expat/configured
        emmake make install
 
+build/lib/brotli/js/decode.js: build/lib/brotli/configured
 build/lib/brotli/configured: lib/brotli
-       mkdir -p build/lib/brotli
        rm -rf build/lib/brotli
        cp -r lib/brotli build/lib/brotli
        $(foreach file, $(wildcard $(BASE_DIR)build/patches/brotli/*.patch), patch -d "$(BASE_DIR)build/lib/brotli" -Np1 -i $(file) && ) true
@@ -305,7 +304,7 @@ EMCC_COMMON_ARGS = \
 
 dist: src/subtitles-octopus-worker.bc dist/js/subtitles-octopus-worker.js dist/js/subtitles-octopus-worker-legacy.js dist/js/subtitles-octopus.js
 
-dist/js/subtitles-octopus-worker.js: src/subtitles-octopus-worker.bc src/pre-worker.js src/SubOctpInterface.js src/post-worker.js
+dist/js/subtitles-octopus-worker.js: src/subtitles-octopus-worker.bc src/pre-worker.js src/SubOctpInterface.js src/post-worker.js build/lib/brotli/js/decode.js
        mkdir -p dist/js
        emcc src/subtitles-octopus-worker.bc $(OCTP_DEPS) \
                --pre-js src/pre-worker.js \
@@ -315,7 +314,7 @@ dist/js/subtitles-octopus-worker.js: src/subtitles-octopus-worker.bc src/pre-wor
                -s WASM=1 \
                $(EMCC_COMMON_ARGS)
 
-dist/js/subtitles-octopus-worker-legacy.js: src/subtitles-octopus-worker.bc src/pre-worker.js src/SubOctpInterface.js src/post-worker.js
+dist/js/subtitles-octopus-worker-legacy.js: src/subtitles-octopus-worker.bc src/pre-worker.js src/SubOctpInterface.js src/post-worker.js build/lib/brotli/js/decode.js
        mkdir -p dist/js
        emcc src/subtitles-octopus-worker.bc $(OCTP_DEPS) \
                --pre-js src/pre-worker.js \

[TFSThiagoBR98]

I've taken the liberty to push the changes I suggested myself, @TFSThiagoBR98 does it look alright to you?

No problem, thanks

A new commit was added for the patchfile dependencies and the diff between your previous version and the first commit of the new version is this:

Looks good to me

Is there an easy, ideally automated way to test JSO changes beyond mere compilation, btw?

Probably some parts can be tested

[TheOneric]

Is there an easy, ideally automated way to test JSO changes beyond mere compilation, btw?
Probably some parts can be tested

I now managed to get the samples from the gh-pages branch working locally. They almost all seem to work and #58 is now ls working for me (I only tested with this pr applied).
The "almost" here being is that the JWPlayer-sample is not loading, as also noted in #102. From JWPlayer's website it seems like it's a commercial framework with only a time-limited free trial (and I assume the trial-period ended for the link used in gh-pages)? Does it make sense to keep a JWPlayer-demo?

[TFSThiagoBR98]

Does it make sense to keep a JWPlayer-demo?

I don't see any reasons to keep it now, so we can remove it.