Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong licence in package.json and missing attribution in distributed files #99

Closed
TheOneric opened this issue May 16, 2021 · 0 comments · Fixed by #105
Closed

Wrong licence in package.json and missing attribution in distributed files #99

TheOneric opened this issue May 16, 2021 · 0 comments · Fixed by #105
Labels

Comments

@TheOneric
Copy link
Member

TheOneric commented May 16, 2021

Currently SubtitlesOctopus declares the wrong licence in its package.json (mostly relevant for npm releases I assume) as the binaries also include other libraries.
Additionaly JSO also falls short of properly crediting the authors of bundled libraries, which is also violates the licences of said bundled libraries (relevant for all binary releases/distributions) — and even JSO's own licence.

Afai understand subtitles-octopus.js will always accompany any JSO binaries distributed (meaning both for stuff we release via GHA artificats and on npm, and what end users will get served from a server). If that's correct adding the attribution and copyright notices to the distributed version of subtitles-octopus.js, seems like a good option.

This is a blocker for a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant