You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently SubtitlesOctopus declares the wrong licence in its package.json (mostly relevant for npm releases I assume) as the binaries also include other libraries.
Additionaly JSO also falls short of properly crediting the authors of bundled libraries, which is also violates the licences of said bundled libraries (relevant for all binary releases/distributions) — and even JSO's own licence.
Afai understand subtitles-octopus.js will always accompany any JSO binaries distributed (meaning both for stuff we release via GHA artificats and on npm, and what end users will get served from a server). If that's correct adding the attribution and copyright notices to the distributed version of subtitles-octopus.js, seems like a good option.
This is a blocker for a new release.
The text was updated successfully, but these errors were encountered:
Currently SubtitlesOctopus declares the wrong licence in its package.json (mostly relevant for npm releases I assume) as the binaries also include other libraries.
Additionaly JSO also falls short of properly crediting the authors of bundled libraries, which is also violates the licences of said bundled libraries (relevant for all binary releases/distributions) — and even JSO's own licence.
Afai understand
subtitles-octopus.js
will always accompany any JSO binaries distributed (meaning both for stuff we release via GHA artificats and on npm, and what end users will get served from a server). If that's correct adding the attribution and copyright notices to the distributed version ofsubtitles-octopus.js
, seems like a good option.This is a blocker for a new release.
The text was updated successfully, but these errors were encountered: