Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When new release will be published? #94

Closed
cawa-93 opened this issue May 12, 2021 · 12 comments
Closed

When new release will be published? #94

cawa-93 opened this issue May 12, 2021 · 12 comments
Labels

Comments

@cawa-93
Copy link
Contributor

cawa-93 commented May 12, 2021

I will import JavascriptSubtitlesOctopus as a native ES module. And this causes an error when initializing:

Uncaught TypeError: 'caller', 'callee', and 'arguments' properties may not be accessed on strict mode functions or the arguments objects for calls to them
    at HTMLVideoElement.<anonymous> (subtitles-octopus.js:205)

After researching, I found out that this problem was fixed by 70d499e 7 months ago. However, it is still relevant for the latest published version

@TFSThiagoBR98
Copy link
Collaborator

TFSThiagoBR98 commented May 12, 2021

Probably this weekend, release on hold until we fix the licensing problems

@TheOneric
Copy link
Member

Currently SubtitlesOctopus declares the wrong licence in its package.json (relevant for npm releases I assume) and falls short of properly crediting the authors of bundled libraries, which is also violates the licences of aid bundled libraries (relevant for all binary releases/distributions) — and even JSO's own licence.

I believe we should hold off on a new release until these issues are fixed.

@TFSThiagoBR98
Copy link
Collaborator

@TheOneric is probably better to open a new issue for the license problem

@SoniEx2
Copy link

SoniEx2 commented Aug 9, 2021

What's currently blocking this? We see #99 is closed?

@heyaco
Copy link

heyaco commented Feb 6, 2022

Has the licensing issue been dealt with? Would be nice for a release after 2yrs+

@zoriya
Copy link
Contributor

zoriya commented Sep 22, 2022

I'm sorry to be bump this again, but I think updating the npm package would be a good thing. I don't want to use a submodule on a frontend project to include this library x)

@SoniEx2
Copy link

SoniEx2 commented Sep 22, 2022

we don't wanna explain to mozilla why we're not using a proper release in a browser extension

@zoriya
Copy link
Contributor

zoriya commented Sep 22, 2022

I'm sorry, I don't understand what you mean.

@SoniEx2
Copy link

SoniEx2 commented Sep 22, 2022

@zoriya
Copy link
Contributor

zoriya commented Sep 23, 2022

SubtitileOctopus is not a Firefox add-on, this is a npm package. This policy does not concern this project

@SoniEx2
Copy link

SoniEx2 commented Sep 23, 2022

no it really does if you're trying to use it as part of an addon for any reason. see https://soniex2.autistic.space/posts/2022/03/06-occf.xhtml

@Helvio88
Copy link

Helvio88 commented Oct 2, 2022

I have a PR pending on this issue. Any idea when it could be approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants