-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When new release will be published? #94
Comments
|
Currently SubtitlesOctopus declares the wrong licence in its I believe we should hold off on a new release until these issues are fixed. |
@TheOneric is probably better to open a new issue for the license problem |
What's currently blocking this? We see #99 is closed? |
Has the licensing issue been dealt with? Would be nice for a release after 2yrs+ |
I'm sorry to be bump this again, but I think updating the npm package would be a good thing. I don't want to use a submodule on a frontend project to include this library x) |
we don't wanna explain to mozilla why we're not using a proper release in a browser extension |
I'm sorry, I don't understand what you mean. |
https://extensionworkshop.com/documentation/publish/add-on-policies/#development-practices can't use dev versions |
SubtitileOctopus is not a Firefox add-on, this is a npm package. This policy does not concern this project |
no it really does if you're trying to use it as part of an addon for any reason. see https://soniex2.autistic.space/posts/2022/03/06-occf.xhtml |
I have a PR pending on this issue. Any idea when it could be approved? |
I will import JavascriptSubtitlesOctopus as a native ES module. And this causes an error when initializing:
After researching, I found out that this problem was fixed by 70d499e 7 months ago. However, it is still relevant for the latest published version
The text was updated successfully, but these errors were encountered: