Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features_dtype arg to collate_features function #1456

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

t13m
Copy link
Contributor

@t13m t13m commented Feb 20, 2025

, to allow user specify custom data type instead of torch.float in default. It's used for collate discrete code features (like in VQ codecs), which are always be in int types.

pzelasko
pzelasko previously approved these changes Feb 21, 2025
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pzelasko pzelasko enabled auto-merge (squash) February 21, 2025 22:10
@pzelasko pzelasko added this to the v1.30 milestone Feb 21, 2025
@t13m
Copy link
Contributor Author

t13m commented Feb 24, 2025

Do I need to reformat the code to pass the black formatter check?

@pzelasko
Copy link
Collaborator

pzelasko commented Mar 4, 2025

Yes

auto-merge was automatically disabled March 5, 2025 01:54

Head branch was pushed to by a user without write access

@pzelasko pzelasko enabled auto-merge (squash) March 5, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants