Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug reported in issue #117 with data.table #118

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix bug reported in issue #117 with data.table #118

merged 1 commit into from
Oct 19, 2023

Conversation

lmsimp
Copy link
Collaborator

@lmsimp lmsimp commented Oct 19, 2023

This PR fixes and addresses issue #117. Specifically,

  • A new function convertMatsToCols has been added which checks the fData for any columns that may be a matrix e.g. TAGM joint probability results, and then explicitly adds the columns of the matrix to the fData of the MSnSet object
  • The columns of the matrix can now be explictly selected in the "Table Selection" tab of the GUI
  • The function makeMatsVecs has been removed as is redundant

@lmsimp lmsimp merged commit b0ce38e into master Oct 19, 2023
0 of 2 checks passed
@lgatto
Copy link
Owner

lgatto commented Oct 23, 2023

does this need to be pushed to Bioc ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants