feat: modernize links in header. no one will print it anyway

lfilho · Aug 16, 2024 · 07b4399 · 07b4399
1 parent 99b4fe2
commit 07b4399
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/src/components/cv/cvData.d.ts b/src/components/cv/cvData.d.ts
@@ -17,7 +17,7 @@ interface URL {
 interface Contact {
     phone: { raw: string; formatted: string };
     url: URL;
-    email: string;
+    email: URL;
     linkedin: URL;
     twitter?: URL;
     topmate: URL;
@@ -47,7 +47,7 @@ interface VolunteerXp {
     keywords: string[];
 }
 
-interface Experience {}
+interface Experience { }
 
 interface Degree extends Event {
     school: string;

diff --git a/src/components/cv/cvData.ts b/src/components/cv/cvData.ts
@@ -14,24 +14,24 @@ export const cvData: CVData = {
         contact: {
             phone: { raw: '', formatted: '' },
             url: { href: 'https://luiz.dev', display: 'www.luiz.dev' },
-            email: '[email protected]',
+            email: { href: '[email protected]', display: 'Email' },
             linkedin: {
                 href: 'https://linkedin.com/in/luizgonzaga',
-                display: 'linkedin.com/in/luizgonzaga',
+                display: 'LinkedIn',
             },
             topmate: {
                 href: 'https://topmate.io/luizgonzaga',
-                display: 'topmate.io/luizgonzaga',
+                display: 'Topmate',
             },
             // twitter: {
             //     href: 'https://twitter.com/luizmarelo',
-            //     display: 'twitter.com/luizmarelo',
+            //     display: 'Twitter',
             // },
             speakerdeck: {
                 href: 'https://speakerdeck.com/lfilho',
-                display: 'speakerdeck.com/lfilho',
+                display: 'SpeakerDeck',
             },
-            github: { href: 'https://github.com/lfilho', display: 'github.com/lfilho' },
+            github: { href: 'https://github.com/lfilho', display: 'GitHub' },
         },
         introduction: [
             `A brazillian-canadian people-first leader building impactful products and high-performing teams for ~{{CAREER_TENURE}} years.`,

diff --git a/src/components/cv/sections/header/index.tsx b/src/components/cv/sections/header/index.tsx
@@ -71,8 +71,8 @@ export default class Header extends Component {
                         <li className='contact mail'>
                             <FontAwesomeIcon icon={faEnvelope} fixedWidth />
                             <span>
-                                <a className='u-email' href={'mailto:' + contact.email}>
-                                    {contact.email}
+                                <a className='u-email' href={'mailto:' + contact.email.href}>
+                                    {contact.email.display}
                                 </a>
                             </span>
                         </li>