Fix subtraction of wait_until_time not accounting for NEVER #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subtraction of the
_lf_action_delay_table
entry from thewait_until_time
value is causing issues.When the
after
keyword is used the delay is set accordingly. But when theafter
keyword is NOT used then the _lf_action_delay_table entry gets set toNEVER
that maps toLLONG_MIN
.According to the inline documentation located shown below and located at https://github.com/lf-lang/lingua-franca/blob/0bb4bf973f24c3f484e42fa0816af3315ff6828d/core/src/main/java/org/lflang/federated/extensions/CExtensionUtils.java#L163
As the
NEVER
value is a special value within reactor-c I am assuming this is a reactor-c issue and not an LF generation issue.I did a inline check to replace
NEVER
with 0. Let me know if a different solution is preferred.