Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add highlight provider #71

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pinbraerts
Copy link
Contributor

Reused code from vim.show_pos. Tried to override vim.api.nvim_echo, but it is extremely unsafe and messed up gui a bit. Then I tried to capture output of the command into buffer but that droped highlights.

I use vim.o.cmdheight = 0 and status bar blinks. Looks like something is blocking gui. Leaving it as draft until I figure out why.

@pinbraerts
Copy link
Contributor Author

photo_2024-06-17_23-37-02

@pinbraerts
Copy link
Contributor Author

pinbraerts commented Jun 18, 2024

Reduced number of calls to nvim api, but that seems to do nothing. Also I noticed that other bufnr provider (man) cause the same flickering of the status/command line. I'll report that as a different issue.

The provider is ready to squash and merge.

EDIT: cleared some cache files, removed and restored all files in config, updated lazy and suddenly the problem is gone

@pinbraerts pinbraerts marked this pull request as ready for review June 18, 2024 08:17
@pinbraerts
Copy link
Contributor Author

Also the documentation states that priority is optional, but it is not marked as optional in luadocs, which leads to lua-ls complaining. Is it optional or not? Should I give it some priority? I want it to be the lowest priority by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant