Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getrandom #3589

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Remove getrandom #3589

merged 4 commits into from
Feb 13, 2025

Conversation

martinfrances107
Copy link
Contributor

@martinfrances107 martinfrances107 commented Feb 12, 2025

This warning

"warning: Feature js of package getrandom has been obsolete in version 0.3.1"

Now using the feature "wasm_js"

Just a small maintence nudge

@martinfrances107
Copy link
Contributor Author

I see the problem, I need to run the equivalent of

RUSTFLAGS='--cfg getrandom_backend="linux_getrandom"' cargo build

config.toml files have a stange quirk when using workspaces

only .cargo/config.toml files in the root directory are recongnised

@martinfrances107
Copy link
Contributor Author

ok so the rustflags need to be platform sepecfic - to take care of windows etc

@martinfrances107
Copy link
Contributor Author

My bad I was not asking the question what uses getrandom ... nothing

@martinfrances107 martinfrances107 changed the title Resolved this warning see while running cargo outdated Remove getrandom Feb 12, 2025
@benwis
Copy link
Contributor

benwis commented Feb 12, 2025

For this conflict, can you run a cargo build so that it updates the Cargo.lock?

@martinfrances107
Copy link
Contributor Author

Fixed

@benwis
Copy link
Contributor

benwis commented Feb 13, 2025

Thanks!

@benwis benwis merged commit 96b125d into leptos-rs:main Feb 13, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants