RenderHtml::into_owned #3580
Merged
RenderHtml::into_owned #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ci i think successful, semver and an unrelated clippy lint are only failures. |
|
Might be worth rebasing against the latest main, but it looks good to me and ready for merging
…On Mon, Feb 10, 2025, at 11:07 AM, zakstucke wrote:
Ci i think successful, semver and an unrelated clippy lint are only failures.
—
Reply to this email directly, view it on GitHub <#3580 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVBTCMHE5DZQKAXWL7OVH32PD2FRAVCNFSM6AAAAABW3HQWJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBYHE3TSNBXGU>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Assuming you mean 0.7 main, I'll do it in the next PR so I don't have to run CI again here, i've got another one lined up after this. |
|
Ship it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here this allows removing the static requirement from
IntoAnyto prevent compile errors on switching to erased mode.