Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement username/usernames queries #997

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

juangm
Copy link
Collaborator

@juangm juangm commented Dec 4, 2024

No description provided.

@juangm juangm requested a review from cesarenaldi December 4, 2024 15:56
@juangm juangm self-assigned this Dec 4, 2024
Copy link

height bot commented Dec 4, 2024

This pull request has been linked to 1 task:

💡Tip: Add "Close T-23199" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: 91a89ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ⬜️ Ignored (Inspect) Dec 11, 2024 9:28am

id
}
owner
# TODO: Implement rules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think gql.tada likes GQL comments, does it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't complain when I do pnpm run check so I guess it is fine 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

over on the types generated from it, if you get never it failed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juangm did you check if the type is usable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed the comments, when we have the rules properly defined I will add where needed

Copy link
Member

@cesarenaldi cesarenaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a failing test that seems something new.

@juangm
Copy link
Collaborator Author

juangm commented Dec 9, 2024

There is a failing test that seems something new.

I just merged with latest next branch and now everything is fine.

@juangm juangm merged commit 129ae5a into next Dec 11, 2024
3 checks passed
@juangm juangm deleted the T-23199/js-action-username-usernames-queries branch December 11, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants