Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fetchApp #973

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Implement fetchApp #973

merged 3 commits into from
Nov 27, 2024

Conversation

juangm
Copy link
Collaborator

@juangm juangm commented Nov 27, 2024

No description provided.

Copy link

height bot commented Nov 27, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: cdcdf17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ❌ Failed (Inspect) Nov 27, 2024 5:48pm

@juangm juangm requested a review from cesarenaldi November 27, 2024 15:31
fragment Feed on Feed {
address
}
`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we attach the beginning and ending of strings with backticks to the strings so to achieve some formatting consistency?

  `fragment AppMetadata on AppMetadata {
      __typename
      description
      developer
      logo
      name
      platforms
      privacyPolicy
      termsOfService
      url
    }`
    
    ...
    
  `fragment App on App {
      __typename
      address
      graphAddress
      sponsorshipAddress
      defaultFeedAddress
      namespaceAddress
      treasuryAddress
      createdAt
      metadata {
        ...AppMetadata
      }
    }`
    
    ...
    
    `fragment Feed on Feed {
      address
    }`

@juangm juangm merged commit 8817c09 into next Nov 27, 2024
2 of 3 checks passed
@juangm juangm deleted the fetch-app branch November 27, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants