indian format bug fixed #19
Conversation
|
Thank you very much 😄 Looks like this PR will fix the issue #16 . |
|
|
||
| lc := LocaleInfo["INR"] | ||
| ac := accounting.Accounting{Symbol: lc.ComSymbol, Precision: 2, Thousand: lc.ThouSep, Decimal: lc.DecSep} | ||
| fmt.Println(ac.FormatMoney(500000)) // "$500,000.00" |
There was a problem hiding this comment.
I have some comments for this test 😄
-
Could you change the code to use
AssertEqualinstead of just printing it like below line?
accounting/formatnumber_test.go
Line 12 in 17a4ce5
-
And I think you can move this test into the formatnumber_test.go file because this code actually tests the formatnumber function.
-
I think you don't need to copy & paste the Locale struct into the test file. I think testing
FormatNumberdirectly with"₹"parameter is enough because it isunit test😄
| @@ -105,8 +139,8 @@ func FormatNumberInt(x int, precision int, thousand string, decimalStr string) s | |||
| var minus bool | |||
|
|
|||
| if x < 0 { | |||
| if x * -1 < 0 { | |||
| return FormatNumber(x, precision, thousand, decimalStr) | |||
| if x*-1 < 0 { | |||
There was a problem hiding this comment.
Could you explain this formatting convention? 😄
|
Searching for similar formatting system I found this can solve the problem of number formatting : p := message.NewPrinter(language.Hindi)
p.Printf("%s %f", "₹", 100000000.0)playground: https://go.dev/play/p/bJMKuCYM2JZ |
No description provided.