Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian translation of NNG4 #84

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Conversation

dalps
Copy link

@dalps dalps commented Jan 5, 2025

Here's an Italian translation of the game.

It's still somewhat rough, and seeing it in context (as in playing the game in Italian) would really help improve the quality of the translated messages.

Is there a way to see it in action, perhaps deploy the PO file to the development server of the game? I couldn't hack it out so I'd appreciate your help.

@kbuzzard
Copy link
Member

kbuzzard commented Jan 5, 2025

I'm afraid I can't help with any of your technical questions, but I would like to say a huge thank-you for doing this translation.

I don't know anything about the server side of things, but when I develop NNG4 I run the game locally. I have lean4game cloned in the same directory as NNG4 and I follow the running locally instructions -- I just type npm start in the lean4game repo and then point my browser at http://localhost:3000/#/g/local/NNG4. If I do this on your branch and go to Preferences in the burger menu in the top right I don't get an Italian option though :-(

Screenshot from 2025-01-05 16-19-05

@dalps
Copy link
Author

dalps commented Jan 5, 2025

Alright I got it to work! As usual, I skipped some of the instructions 🙃

What's missing is the Game.json file generated by lake exe i18n --export-json and the localization files in lean4game. I have pushed both. So now, if you clone my fork of lean4game, which is configured for Italian, alongside my fork of NNG4 and run the game server, hopefully you should be seeing the Italian option under Preferences!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants