Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix digest mapping for scram auth #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fffonion
Copy link

@fffonion fffonion commented Jun 29, 2023

From Kong#20.

In OpenSSL 3.0 where RSA-SHA256 is no longer a valid digest name. This commit fix such use case.
This fix also covers the cases like ecdsa-with-X so the previous block so the manual mapping could be removed.

But I have two thoughts needs discussion:

  • This change adds the dependency of lua-resty-openssl even if self.sock_type is not nginx and not cqueues, is that okay?
  • I might need some help on adding test of this in CI

@fffonion fffonion force-pushed the fix-sigid branch 2 times, most recently from 552b666 to 0766862 Compare June 29, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant