Sync `libasr` with LFortran #2628

czgdp1807 · 2024-03-25T09:56:53Z

No description provided.

src/libasr/ASR.asdl

src/libasr/CMakeLists.txt

Thirumalai-Shaktivel · 2024-03-25T10:37:12Z

src/libasr/codegen/asr_to_llvm.cpp

        for( size_t i = 0; i < x.n_args; i++ ) {
-            if (is_argument_of_type_CPtr(x.m_args[i])) {


src/libasr/codegen/asr_to_llvm.cpp

src/libasr/utils.h

Thirumalai-Shaktivel · 2024-03-25T10:44:35Z

src/libasr/pass/unique_symbols.cpp


-
-    const std::unordered_set<std::string> reserved_keywords_c = {
-        "_Alignas", "_Alignof", "_Atomic", "_Bool", "_Complex", "_Generic", "_Imaginary", "_Noreturn", "_Static_assert", "_Thread_local", "auto", "break", "case", "char", "_Bool", "const", "continue", "default", "do", "double", "else", "enum", "extern", "float", "for", "goto", "if", "int", "long", "register", "return", "short", "signed", "sizeof", "static", "struct", "switch", "typedef", "union", "unsigned", "void", "volatile", "while"


Thirumalai-Shaktivel · 2024-03-25T10:46:26Z

src/libasr/pass/replace_symbolic.cpp

@@ -49,263 +49,20 @@ class ReplaceSymbolicVisitor : public PassUtils::PassVisitor<ReplaceSymbolicVisi
    std::set<ASR::symbol_t*> symbolic_vars_to_omit;
    SymEngine_Stack symengine_stack;

-    /********************************** Utils *********************************/
-    #define BASIC_CONST(SYM, name)                                              \


Some or maybe all the changes has to be reverted in this file : #2433

src/libasr/pass/replace_symbolic.cpp

src/libasr/pass/intrinsic_function_registry.h

src/libasr/pass/pass_manager.h

src/libasr/pass/pass_utils.h

src/libasr/codegen/asr_to_c.cpp

src/libasr/codegen/asr_to_c_cpp.h

src/libasr/diagnostics.cpp

src/libasr/string_utils.cpp

src/libasr/pickle.cpp

czgdp1807 · 2024-03-25T19:28:34Z

I am able to compile 40% of integration_tests. Will continue debugging tomorrow and complete this PR.

src/libasr/pass/replace_symbolic.cpp

src/libasr/pass/pass_manager.h

src/libasr/pass/function_call_in_declaration.cpp

src/libasr/pass/intrinsic_array_function_registry.h

src/libasr/pass/intrinsic_subroutine.cpp

Pranavchiku

Left comments above, otherwise this looks good. Thanks for doing this, it was tricky to even review.

anutosh491 · 2024-03-26T14:22:54Z

I was going through the Run SymPy tests job and it seems symbolics_13.py fails with the llvm_sym backend. I remember Ondrej and I adressed this very carefully (the same issue is referenced here ) and we have the reqd changes here to execute the test. On the surface everything looks fine so might need some digging.

If everything is done in this pr and that's the only thing blocking us, maybe comment out llvm_sym from symbolics_13 for now and then debug it separately.

certik · 2024-03-26T14:25:53Z

@anutosh491 can you please help debugging the symbolic issue? That way @czgdp1807 can focus on syncing with LFortran.

certik · 2024-03-26T17:33:16Z

tests/reference/asr-bindc_03-95dbba7.stderr

+
+
+Note: Please report unclear or confusing messages as bugs at
+https://github.com/lcompilers/lpython/issues.


All error reference tests now have this text, it used to be disabled via --no-error-banner.

Separate issue. Same thing is there in LFortran.

certik · 2024-03-26T17:35:02Z

Other than that, I think this is good. I verified changes to:

ASR.asdl: it seems nothing was removed that should be there
tests: it seems all tests pass and no tests were modified (there are some minor changes that are fine for now).

Thirumalai-Shaktivel reviewed Mar 25, 2024

View reviewed changes