removal of style-suggestion #2518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@certik please review it |
certik
reviewed
Feb 9, 2024
| "outfile": null, | ||
| "outfile_hash": null, | ||
| "stdout": "asr-test_builtin_pow-f02fcda.stdout", | ||
| "stdout_hash": "b0aa9ff1f31769b515e2aedd650656b6a53676d5bf276e6b9a4b12b9", | ||
| "stderr": "asr-test_builtin_pow-f02fcda.stderr", | ||
| "stderr_hash": "859ce76c74748f2d32c7eab92cfbba789a78d4cbf5818646b99806ea", | ||
| "stderr_hash": "5e6ebe611731fa5e2e5ceeb0cdf57995915453486fdfc06bd9ecb3fb", |
There was a problem hiding this comment.
The error is still there. You removed tests/reference/asr-test_builtin_pow-f02fcda.stderr, which doesn't need to be there, but LPython still gives the error message.
There was a problem hiding this comment.
@certik give some suggestions, should i remove "stderr_hash" from tests/reference/asr-test_builtin_pow-f02fcda.json.
There was a problem hiding this comment.
You need to fix LPython not to give this warning when # noqa is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removal of style suggestion mentioned in issue #2478