Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes empty string bug in str isalpha method #2484

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

advikkabra
Copy link
Collaborator

In the current implementation of the isalpha() method, an empty string returns a True value, but in CPython it returns False.

@anutosh491
Copy link
Collaborator

Good catch @advikkabra
Do you see any more builtin methods where we might be going wrong in corner cases like this ?
Would be great if you could give it a look.

Also the CI failing for the macos build isn't due to your commit, so no need to worry about it.

@certik certik merged commit 20b93b4 into lcompilers:main Feb 7, 2024
12 of 13 checks passed
@advikkabra advikkabra deleted the isalpha-fix branch February 18, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants