Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify vendor data and corrections #31

Merged
merged 12 commits into from
Jan 27, 2025
Merged

Simplify vendor data and corrections #31

merged 12 commits into from
Jan 27, 2025

Conversation

benjay10
Copy link
Collaborator

[DL-6328]

Documentation updates that go alongside the simplifications of the Vendor API model in Loket.

Main changes include:

  • Updated diagrams to correspond to the model in table form
  • Rewording of predicate names
  • Removed uuid from the models, the vendor has no use of them
  • Added a missing property on the SubmissionDocument
  • Updated the snippet for downloading attachments: there is already a downloadlink in the vendor data on Worship Submissions Database.

benjay10 added 12 commits January 22, 2025 03:21
@benjay10
Move diagram to the top of the model description
8c7481f
@benjay10
Meldingsplicht: add RDF type
3a959e9
@benjay10
Meldingsplicht: add warning of lesser used predicates
e1aaa6f
@benjay10
Meldingsplicht: new simpler diagram
1bd7ac8 
No more data that is not in the Vendor API anymore.
@benjay10
Diagrams: added forgotten properties
a6698d6
@benjay10
Meldingsplicht: removed attachments from model
5a4b3be 
As far as I can see, not all Submissions have a nie:hasPart.
@benjay10
Move download attachment script to worship database
a3190e8
@benjay10
Diagrams: merge two properties for clarity
0f2cc73
@benjay10
Worship model: nicer descriptions
0b0b620 
Properties with nicer names.
@benjay10
Worship model: added missing property
542a61e 
And reworded the introduction to make more clear that this is all the
data that will be presented in the API.
@benjay10
Diagrams: updated to updated model
5a5961e
@benjay10
Worship: download attachments corrections
c605165 
Moved the snippet file to the correct folder and correct the hostname,
and used the download URL in the triplestore. No need for manual
calculations.
@benjay10 benjay10 added the enhancement New feature or request label Jan 24, 2025
@benjay10 benjay10 requested a review from cecemel January 24, 2025 02:44
cecemel
cecemel approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@cecemel cecemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you also deploy this?

@benjay10 benjay10 merged commit 92346e1 into master Jan 27, 2025
@benjay10 benjay10 deleted the simplify-vendor-data branch January 27, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecemel cecemel cecemel approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjay10 @cecemel